Export gzfwrite() #6880
Closed
Export gzfwrite() #6880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xdebug recently introduced the possibility to compress profile information and this uses `gzfwrite()`, what is not yet exported on Windows. That would require run-time linking to be worked around.
nikic
approved these changes
Apr 26, 2021
|
Well, might not actually be necessary for Xdebug, but maybe for others. |
cmb69
added a commit
to cmb69/xdebug
that referenced
this pull request
Sep 15, 2021
`gzfwrite` is not exported prior to PHP 7.4.20, see <php/php-src#6880>.
derickr
pushed a commit
to xdebug/xdebug
that referenced
this pull request
Sep 21, 2021
`gzfwrite` is not exported prior to PHP 7.4.20, see <php/php-src#6880>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xdebug recently introduced the possibility to compress profile
information and this uses
gzfwrite(), what is not yet exported onWindows. That would require run-time linking to be worked around.
Alternatively, we could fully update to https://github.com/winlibs/zlib/blob/master/win32/zlib.def.
As 7.4 RM and Xdebug maintainer, @derickr might be interested in this.